fix: add media type for cmdline #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #247 +/- ##
=======================================
Coverage 90.63% 90.63%
=======================================
Files 42 42
Lines 2008 2008
=======================================
Hits 1820 1820
Misses 188 188 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@yeoldegrove @NotTheEvilOne can you take care of improving the error message, merging this and releasing a new version today so our nightly works again tomorrow? |
NotTheEvilOne
approved these changes
Nov 5, 2025
| "squashfs", | ||
| "manifest", | ||
| "vmlinuz", | ||
| "cmdline", |
Contributor
There was a problem hiding this comment.
I'm not really happy with the file name itself as I personally would prefer cmdline.txt here. For the current state please go ahead anyway. I would highly appreciate if we could revisit the file name and it's use case thought.
Signed-off-by: Tobias Wolf <wolf@b1-systems.de> On-behalf-of: SAP <tobias.wolf@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.