feat: decouple S3 upload from features directory #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Added a |
nkraetzschmar
force-pushed
the
feat/decouple_upload
branch
from
2ebc658 to
ce32bb0
Compare
nkraetzschmar
added a commit
to gardenlinux/gardenlinux
that referenced
this pull request
Nov 6, 2025
…release This value is going to be consumed by the changed upload logic of gardenlinux/python-gardenlinux-lib#249 Additionally add the optional GARDENLINUX_PLATFORM_VARIANT key for openstack images
nkraetzschmar
added a commit
to gardenlinux/gardenlinux
that referenced
this pull request
Nov 6, 2025
…release This value is going to be consumed by the changed upload logic of gardenlinux/python-gardenlinux-lib#249 In cases where there are unexpectedly more or less then 1 platform active this value will be replaced with "frankenstein" to indicate something went wrong Additionally add the optional GARDENLINUX_PLATFORM_VARIANT key for openstack images
Gchbg
approved these changes
Nov 6, 2025
Contributor
|
Decoupeling of canonical name handling from a |
commel
pushed a commit
to gardenlinux/gardenlinux
that referenced
this pull request
Nov 10, 2025
…release This value is going to be consumed by the changed upload logic of gardenlinux/python-gardenlinux-lib#249 In cases where there are unexpectedly more or less then 1 platform active this value will be replaced with "frankenstein" to indicate something went wrong Additionally add the optional GARDENLINUX_PLATFORM_VARIANT key for openstack images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uploading build artifacts should be trivially doable using just the artifacts. no need to require the features directory which till no was implicitly required by using
cname_object = CName(cname)Besides simplifying the upload logic this is also crucially important if (as is currently the case in the main GL repo) the publish logic runs from the main branch, even when publishing artifacts from a
rel-Xbranch, since there are zero guarantees that the features directory from the main branch will behave identical to the release branch for the same cname.