Fixed encoding bug in python3 #13
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… python3 - Happens because python3 HTTPResponse, when read like a file (e.g. with `json.load`), assumes binary - see: https://stackoverflow.com/questions/23049767/parsing-http-response-in-python - Updated test mocks to make unit tests pass
2 similar comments
|
I'm trying to use jupyter-enterprise-gateway, which depends on this project, and am also encountering this issue. |
| class Response(object): | ||
| def __init__(self, http_response): | ||
| self.data = json.load(http_response) | ||
| self.data = json.loads(http_response.read().decode(http_response.headers.get_content_charset('utf-8'))) |
Collaborator
There was a problem hiding this comment.
I like how it's implemented in #7 , but there content charset is not taken into account.
Perhaps use codecs module in combination with http_response.headers.get_content_charset('utf-8') ?
Collaborator
|
@adamkewley please rebase from master and bump version as well |
Collaborator
|
This might become obsolete with PR #16 and move to use requests package. |
Collaborator
|
This can be probably already closed since this code is no longer present (due to direct call to json() via requests) |
Member
|
This code is no longer applicable - closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
json.load), assumes binary