API Request Throttling (with milestones) #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding milestone support and throttling requests down below the GitHub abuse threshold for concurrent open requests by a single user. Also doing a little bit of cleanup on the JSON so that the API doesn’t barf over empty values.
Owner
|
@kwhite thanks so much for the PR! Great to see someone else getting use of the tools. The code looks good to me; I'll test it later today or tomorrow and then merge it in. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I was using your awesome package to import a slew of issues, and bumped up against the abuse rate limit. GitHub will only allow ~25 concurrent content creation requests from a single GitHub user before it shuts you down. So I've added bottleneck and some simple throttling to keep this to 20 open requests sent 200ms apart.
I also added milestones (because I needed them) and did a little work on the JSON output; for me, if I had an empty string value in the labels array for some requests GitHub was not happy with me.
Hope this is helpful!