Skip to content

Conversation

@azeey
Copy link
Contributor

@azeey azeey commented Dec 2, 2025

🎉 New feature

Builds on top of #652

Summary

Also adds some warnings about the use of the service for setting twists on Harmonic.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Generated-by: Remove this if GenAI was not used.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Dec 3, 2025
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is wrong here. This PR is the same as #652 but the branch names are different.

Did you push your code in the rithg brnahc @azeey ?

Also the title doesn't correspond with the content

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey force-pushed the add_set_entity_state branch from d832afa to 86b2c25 Compare December 3, 2025 16:33
@azeey
Copy link
Contributor Author

azeey commented Dec 3, 2025

It had one additional commit on top of #652. When working from a fork, it's not possible to target an existing PR, so I had to include all of #652 and the additional commit in this PR. Now that #652 is merged, I have rebased and this can now be reviewed on its own.

@azeey azeey merged commit 55dfcd5 into gazebosim:master Dec 3, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants