Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the light visual logic from RenderUtil to Scene3d. #633

Open
ahcorde opened this issue Feb 17, 2021 · 0 comments
Open

Move the light visual logic from RenderUtil to Scene3d. #633

ahcorde opened this issue Feb 17, 2021 · 0 comments
Labels
enhancement New feature or request help wanted We accept pull requests! rendering Involves Ignition Rendering

Comments

@ahcorde
Copy link
Contributor

ahcorde commented Feb 17, 2021

Desired behavior

Move the light visual logic from RenderUtil to Scene3d. The light visuals are only supposed to show on the client scene, not on the server.

Alternatives considered

Refer to this comment #587 (comment)
@ahcorde ahcorde added the enhancement New feature or request label Feb 17, 2021
@ahcorde ahcorde mentioned this issue Feb 17, 2021
Merged
@chapulina chapulina added rendering Involves Ignition Rendering help wanted We accept pull requests! labels Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted We accept pull requests! rendering Involves Ignition Rendering
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ahcorde @chapulina