cmdsim.rb: fix ruby syntax #1884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces File.exists? calls with File.exist? to fix the UNIT_gz_TEST on macOS. It also removes a rescue statement that was hiding useful error messages. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
iche033
approved these changes
Feb 6, 2023
scpeters
added a commit
that referenced
this pull request
Feb 6, 2023
This replaces File.exists? calls with File.exist? to fix the UNIT_gz_TEST on macOS. It also removes a rescue statement that was hiding useful error messages. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
This was referenced Feb 6, 2023
scpeters
added a commit
that referenced
this pull request
Feb 11, 2023
This replaces File.exists? calls with File.exist? to fix the UNIT_gz_TEST on macOS. It also removes a rescue statement that was hiding useful error messages. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Part of #1867.
Summary
This replaces the deprecated/removed
File.exists?calls withFile.exist?to fix theUNIT_gz_TESTon macOS (which uses a very new version of ruby). It also removes arescuestatement that was hiding useful error messages.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.