-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actuators message input for JointController. #1953
Merged
mjcarroll
merged 3 commits into
gazebosim:gz-sim7
from
rudislabs:pr-actuator-jointcontroller
May 12, 2023
Merged
Actuators message input for JointController. #1953
mjcarroll
merged 3 commits into
gazebosim:gz-sim7
from
rudislabs:pr-actuator-jointcontroller
May 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for velocity control of joints with actuators msg. Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
Still need to add tests. |
9 tasks
Codecov Report
@@ Coverage Diff @@
## gz-sim7 #1953 +/- ##
===========================================
+ Coverage 64.62% 65.03% +0.40%
===========================================
Files 348 352 +4
Lines 27859 28468 +609
===========================================
+ Hits 18004 18514 +510
- Misses 9855 9954 +99
|
bperseghetti
force-pushed
the
pr-actuator-jointcontroller
branch
from
April 10, 2023 19:48
92df03d
to
e657126
Compare
@azeey @mjcarroll good to merge now? |
Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
bperseghetti
force-pushed
the
pr-actuator-jointcontroller
branch
from
April 28, 2023 00:17
e657126
to
5d87ee2
Compare
9 tasks
@osrf-jenkins retest this please |
azeey
reviewed
May 9, 2023
Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
mjcarroll
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Adds ability to control the velocity of joints with the velocity field of the actuators message.
Closes: #1973
As seen in the Gazebo community meeting:
https://vimeo.com/812911652#t=39m58s
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.