Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward port 6 to 7 #1977

Merged
merged 6 commits into from
May 3, 2023
Merged

Forward port 6 to 7 #1977

merged 6 commits into from
May 3, 2023

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Apr 28, 2023

➡️ Forward port

Port ign-gazebo6 to gz-sim7

Branch comparison: gz-sim7...ign-gazebo6

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

iche033 and others added 5 commits April 17, 2023 10:12
* Add tutorial on migrating from Light class

---------

Signed-off-by: Ian Chen <ichen@openrobotics.org>

Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
---------

Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 28, 2023
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #1977 (d93a83e) into gz-sim7 (0742968) will decrease coverage by 0.08%.
The diff coverage is 73.30%.

❗ Current head d93a83e differs from pull request most recent head e42d913. Consider uploading reports for the commit e42d913 to get more accurate results

@@             Coverage Diff             @@
##           gz-sim7    #1977      +/-   ##
===========================================
- Coverage    65.08%   65.00%   -0.08%     
===========================================
  Files          352      352              
  Lines        28312    28439     +127     
===========================================
+ Hits         18428    18488      +60     
- Misses        9884     9951      +67     
Impacted Files Coverage Δ
include/gz/sim/rendering/MarkerManager.hh 100.00% <ø> (ø)
include/gz/sim/rendering/RenderUtil.hh 100.00% <ø> (ø)
include/gz/sim/rendering/SceneManager.hh 100.00% <ø> (ø)
src/SimulationRunner.hh 100.00% <ø> (ø)
...rc/systems/ackermann_steering/AckermannSteering.hh 100.00% <ø> (ø)
...int_position_controller/JointPositionController.hh 100.00% <ø> (ø)
src/systems/physics/Physics.cc 67.13% <0.00%> (-0.09%) ⬇️
src/SdfEntityCreator.cc 86.49% <25.00%> (-0.53%) ⬇️
include/gz/sim/EventManager.hh 75.75% <66.66%> (-3.41%) ⬇️
...s/multicopter_motor_model/MulticopterMotorModel.cc 76.40% <69.23%> (+0.48%) ⬆️
... and 7 more

... and 1 file with indirect coverage changes

tutorials/migration_actor_api.md Outdated Show resolved Hide resolved
test/worlds/actor_trajectory.sdf Show resolved Hide resolved
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
@nkoenig nkoenig merged commit 668b757 into gz-sim7 May 3, 2023
@nkoenig nkoenig deleted the nkoenig/6-to-7-20230428 branch May 3, 2023 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants