Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable pybind11 on Windows by default #2005

Merged
merged 5 commits into from
Jun 12, 2023
Merged

Conversation

Crola1702
Copy link
Contributor

🦟 Bug fix

(Copied from gazebosim/gz-math#529)

Fixes part of #2003 (discussion on gazebosim/gz-launch#220)

Summary

This PR disabled pybind11 on windows by default until we fix the Windows build regressions that are related to #2003

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
@Crola1702 Crola1702 requested a review from azeey June 6, 2023 17:06
@Crola1702 Crola1702 self-assigned this Jun 6, 2023
@Crola1702 Crola1702 requested a review from mjcarroll as a code owner June 6, 2023 17:06
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jun 6, 2023
CMakeLists.txt Show resolved Hide resolved
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
@Crola1702 Crola1702 requested a review from azeey June 6, 2023 18:05
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #2005 (782642a) into ign-gazebo6 (c0a7428) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 782642a differs from pull request most recent head 27ef368. Consider uploading reports for the commit 27ef368 to get more accurate results

@@               Coverage Diff               @@
##           ign-gazebo6    #2005      +/-   ##
===============================================
+ Coverage        65.35%   65.37%   +0.01%     
===============================================
  Files              327      327              
  Lines            26996    26996              
===============================================
+ Hits             17644    17648       +4     
+ Misses            9352     9348       -4     

see 3 files with indirect coverage changes

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're still doing find_package(pybind11) on line 206. That should be conditioned on SKIP_PYBIND11.

CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
@Crola1702
Copy link
Contributor Author

I see -- SKIP_PYBIND11 set - disabling python bindings in https://build.osrfoundation.org/job/ign_gazebo-pr-win/5728/. So in theory, it's working fine.

@azeey
Copy link
Contributor

azeey commented Jun 7, 2023

Looks like mac-four is having a permissions issue:

==> Reinstalling 4 dependents with broken linkage from source:
osrf/simulation/ignition-fuel-tools7, osrf/simulation/ignition-gui6, osrf/simulation/ignition-sensors6, osrf/simulation/ignition-transport11
Error: Could not rename ignition-fuel-tools7 keg! Check/fix its permissions:
  sudo chown -R $(whoami) /usr/local/Cellar/ignition-fuel-tools7/7.2.2
Build step 'Execute shell' marked build as failure

Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly fine, some minor comments.

CMakeLists.txt Show resolved Hide resolved
CMakeLists.txt Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
@Crola1702 Crola1702 requested a review from j-rivero June 9, 2023 17:42
@azeey azeey merged commit 090402e into ign-gazebo6 Jun 12, 2023
@azeey azeey deleted the Crola1702/disable-pybind11 branch June 12, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants