-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable pybind11 on Windows by default #2005
Conversation
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo6 #2005 +/- ##
===============================================
+ Coverage 65.35% 65.37% +0.01%
===============================================
Files 327 327
Lines 26996 26996
===============================================
+ Hits 17644 17648 +4
+ Misses 9352 9348 -4 |
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're still doing find_package(pybind11)
on line 206. That should be conditioned on SKIP_PYBIND11
.
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
I see |
Looks like
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly fine, some minor comments.
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
🦟 Bug fix
(Copied from gazebosim/gz-math#529)
Fixes part of #2003 (discussion on gazebosim/gz-launch#220)
Summary
This PR disabled pybind11 on windows by default until we fix the Windows build regressions that are related to #2003
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.