Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libpython3-dev CI dependency #2233

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Nov 8, 2023

🦟 Bug fix

Summary

#2187 introduced cmake and compiler warnings as a result of removing libdart dependencies:

# cmake
-- Searching for Python - not found.
CMake Warning at /usr/share/cmake/gz-cmake3/cmake3/GzConfigureBuild.cmake:68 (message):
   CONFIGURATION WARNINGS:
   -- Python is missing: Python interfaces are disabled.
Call Stack (most recent call first):
  CMakeLists.txt:238 (gz_configure_build)

and

# gcc
/home/jenkins/workspace/gz_sim-ci-gz-sim8-jammy-amd64/gz-sim/src/SimulationRunner.cc:615:29: warning: unused variable ‘release’ [-Wunused-variable]
  615 |       MaybeGilScopedRelease release;

This adds a direct dependency on libpython3-dev as opposed to the indirect dependency we had through libdart-dev. This PR also fixes the compiler warning in case python bindings are disabled.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from mjcarroll as a code owner November 8, 2023 01:42
@azeey azeey self-assigned this Nov 8, 2023
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Nov 8, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #2233 (34c21d0) into gz-sim8 (fdbda58) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 34c21d0 differs from pull request most recent head 32419aa. Consider uploading reports for the commit 32419aa to get more accurate results

@@             Coverage Diff             @@
##           gz-sim8    #2233      +/-   ##
===========================================
+ Coverage    65.66%   65.68%   +0.01%     
===========================================
  Files          324      324              
  Lines        30945    30944       -1     
===========================================
+ Hits         20320    20325       +5     
+ Misses       10625    10619       -6     
Files Coverage Δ
src/SimulationRunner.cc 91.73% <ø> (+0.91%) ⬆️

... and 1 file with indirect coverage changes

@mjcarroll mjcarroll merged commit 86d7ba5 into gazebosim:gz-sim8 Nov 8, 2023
9 of 10 checks passed
@azeey azeey deleted the add_python_dev branch November 8, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants