Allow removal of model that has joint_position_controller plugin. #2252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johan Rutgeerts <johan.rutgeerts@lancewood.eu>
Signed-off-by: Johan Rutgeerts <johan.rutgeerts@lancewood.eu>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## gz-sim8 #2252 +/- ##
===========================================
- Coverage 65.64% 65.63% -0.01%
===========================================
Files 324 324
Lines 30917 30925 +8
===========================================
+ Hits 20295 20299 +4
- Misses 10622 10626 +4 ☔ View full report in Codecov by Sentry. |
arjo129
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
This is a temporary fix for #2165 until #2217 is resolved.