Use parentEntity available in systems instead of storing it for each interface
#2473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h interface Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
8 tasks
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
|
the overall changes of this branch against |
arjo129
approved these changes
Jul 12, 2024
arjo129
reviewed
Jul 12, 2024
arjo129
added a commit
that referenced
this pull request
Jul 12, 2024
This PR is a suggestion for how 2473 can run in O(m+n) time instead of O(mn) where m is number of entities removed and n is number of systems. Signed-off-by: Arjo Chakravarty <arjoc@google.com>
8 tasks
* Slight Improvement in runtime for #2473 This PR is a suggestion for how 2473 can run in O(m+n) time instead of O(mn) where m is number of entities removed and n is number of systems. Signed-off-by: Arjo Chakravarty <arjoc@google.com> * Style Signed-off-by: Arjo Chakravarty <arjoc@google.com> --------- Signed-off-by: Arjo Chakravarty <arjoc@google.com>
scpeters
approved these changes
Jul 12, 2024
azeey
merged commit 7026b57
into
arjo/feat/remove_systems_with_entities
5 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@arjo129 I think it's possible to further simplify #2232 by using the
parentEntityalready available in thesystemsvector. I haven't fully tested this yet, but I wanted get your feedback if there's a downside to this approach.cc @scpeters