Fix of custom header for error column #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using basic math operations on columns, uncertainty columns can be created. However creation of the custom header for such column was not possible. In the first commit of these functions, there was a typo len(header) == 0, later changed to "not header". But neither worked, len of the tupple needs to be two, as for a and b variables on line 2530.
Member
|
Great - thanks ! I need to write some tests for that as well in due course.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using basic math operations on columns, uncertainty columns can be created. However creation of the custom header for such column was not possible. In the first commit of these functions, there was a typo len(header) == 0, later changed to "not header". But neither worked, len of the tupple needs to be two, as for a and b variables on line 2530.