Skip to content

Conversation

@Deigue
Copy link
Contributor

@Deigue Deigue commented Nov 12, 2025

Ok so I did some more looking into the issue since I was a bit puzzled/bothered by not understanding how PyPI packaging works.

Apparently the 'Programming Language :: Python :: 3' specification is just a general specifier for Python 3 compatibility. So nothing too odd about that, left it there as is.

I added a requirement : require 3.10 or above.
I also deliberately nuked my own .venv and purposely created using Python 3.10
(think it is fairly reasonable since the project inception was within a year? And 3.10 dates back to 2021, but still wanted to keep the requirement as minimum as possible)

I removed the other dependencies I had (updated the .gitignore) and just used the setup.py to get the dependencies.
The ruff.toml is just a local linter spec to avoid it from complaining about stuff you had mentioned to keep maintainability (less moving around, easy copy-pastable code)

With all this in, I tested the | pipe notation, and it seems to not be complaining.
Further, I am explicitly seeing linter warnings now (further confirming that it recognizes I am using a 3.10+ python now)
image

But I might need your assistance to try and confirm beforehand if this looks okay.
Since it was always compiling and running without problems, I cant be 100% sure it is fine.
Also feel free to bump up the version to 3.13 if that is fine by you. I just wanted to keep it minimal as possible, but 3.13 should be probably fine.

"Programming Language :: Python :: 3.13" classifier just indicates that it is known/confirmed to work with 3.13

@Deigue
Copy link
Contributor Author

Deigue commented Nov 12, 2025

I can tweak the other places after you confirm it seems to be good on your end.
I didn't want to go ahead and make too many edits before seeing if it works for you, and you were onboard with the idea.

@gboudreau
Copy link
Owner

That seems to work just fine. Go to continue making changes for 3.10+

@Deigue
Copy link
Contributor Author

Deigue commented Nov 14, 2025

The only noticeable/significant change is moving get_security into the WealthsimpleAPIBase class. Which now that I think about it makes more sense, since it is being used as a baseline verification method for access, and it should still be identically accessible through WealthsimpleAPI like any other API call.

Also ran through few example invokes in my CLI app, and the README.md example exercising most of the calls and seems to be working without a hitch.

@gboudreau gboudreau merged commit d8392ea into gboudreau:main Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants