[DOC] improve aptacom loader docstrings #192
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
satvshr
reviewed
Nov 6, 2025
|
|
||
| def filter_columns(ds, columns=None): | ||
| """Select columns to keep on dataset. | ||
| def _filter_columns(ds, columns=None): |
Collaborator
There was a problem hiding this comment.
the ds parameter is still confusing as we may use Datasets from hugging face whose abreviation is ds too, for dataframes df is usually used.
satvshr
reviewed
Nov 12, 2025
Collaborator
|
New files introduced? Apart from that, LGTM! |
rpgv
force-pushed
the
aptacom-docstrings
branch
from
6c83192 to
fa942f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improves aptacom loader docstrings - actions the comments by @satvshr that I overlooked in #158.
Sorry for missing these and merging.