Skip to content

Conversation

@gdalle
Copy link
Owner

@gdalle gdalle commented May 26, 2024

Source

  • Re-export and document column_coloring, row_coloring and symmetric_coloring from ADTypes
  • Remove star_coloring1, which was a naive algorithm from 2005
  • Implement star_coloring, a better algorithm from 2007
  • Remove check_structurally_orthogonal_rows since it is achievable with check_structurally_orthogonal_columns by transposition, rename check_symmetrically_orthogonal to check_symmetrically_orthogonal_columns
  • Add size checks and improve the log messages in both remaining checks
  • Rename colors to color and groups to group everywhere to be more coherent with the papers
  • Rename C into B for decompression to be more coherent with the papers
  • Slightly more efficient symmetric recovery algorithm

Tests

  • Add more tests on the checks, including the log messages
  • Remove comparison to the naive star coloring since it has disappeared

Docs

  • Add more sources to the README and docstrings

@codecov
Copy link

codecov bot commented May 26, 2024

Codecov Report

Attention: Patch coverage is 99.23077% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 97.75%. Comparing base (c1b2cf4) to head (2c2c7cd).

Files Patch % Lines
src/decompression.jl 96.87% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
- Coverage   98.52%   97.75%   -0.77%     
==========================================
  Files           9        9              
  Lines         271      312      +41     
==========================================
+ Hits          267      305      +38     
- Misses          4        7       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle merged commit 759ed65 into main May 26, 2024
@gdalle gdalle deleted the gd/betterstar branch June 8, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant