Skip to content

Standardize parsing for all nodes #11

@gdbrown

Description

@gdbrown

From PR #9

  • Number nodes don't have bool operators; that's fine in most cases, except when you change the default value for bool,
  • Emoji, Emoticon, Hashtag, and Mention nodes override "optional" with "required"; this should not happen, IMO, and it's the builder that could force that,
  • getBoolOperator method's implementation isn't complete - I had to re-implement it to change the default value, otherwise using "optional" wouldn't be possible. Adding conditions for "or" would be enough, and I could simply replace the default value for the method argument, and call the method on the parent.

This will require some mods to the query builders but not too bad.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions