Skip to content

Temporary fix of the palace CI#700

Merged
joamatab merged 2 commits into
gdsfactory:mainfrom
David-GERARD:fix/palace-ci
Apr 28, 2026
Merged

Temporary fix of the palace CI#700
joamatab merged 2 commits into
gdsfactory:mainfrom
David-GERARD:fix/palace-ci

Conversation

@David-GERARD
Copy link
Copy Markdown
Contributor

@David-GERARD David-GERARD commented Apr 27, 2026

Summary

As of Palace v0.16.1, building palace from singularity.def is no longer supported.

This PR is a temporary fix that pins the version of the repository to v0.16.0 in the GitHub action workflow to prevent the HTTP error.

A more permanant fix would involve using the newer build procedure.

Related issue

Addresses #699

Summary by Sourcery

CI:

  • Update pages and test_code GitHub workflows to download the Palace Singularity definition from the v0.16.0 tag instead of main.

@David-GERARD David-GERARD requested a review from joamatab as a code owner April 27, 2026 06:17
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented Apr 27, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Temporarily pins the Palace Singularity definition URL in CI workflows to a known-good tagged release (v0.16.0) so that GitHub Actions continue to build and test against a valid Singularity definition despite upstream deprecation.

Sequence diagram for GitHub Actions job using pinned Palace Singularity definition

sequenceDiagram
  participant GH as GitHub_Actions
  participant Job as Pages_Workflow_Job
  participant Runner as Ubuntu_Runner
  participant Palace as Palace_GitHub_Repo
  participant Cache as Actions_Cache

  GH->>Job: Trigger pages workflow
  Job->>Runner: Start job build_pages

  Runner->>Runner: Install libglu1-mesa via apt-get

  Runner->>Palace: HTTP GET /awslabs/palace/refs/tags/v0.16.0/singularity/singularity.def
  Palace-->>Runner: 200 OK singularity.def
  Runner->>Runner: Save singularity.def locally

  Runner->>Cache: Restore cache key palace_container
  Cache-->>Runner: Cache hit or miss

  Runner->>Runner: Build Palace container using singularity.def
  Runner->>Cache: Save updated palace_container cache

  Runner-->>Job: Job completed
  Job-->>GH: Report success
Loading

File-Level Changes

Change Details Files
Pin Palace Singularity definition download in CI workflows to tag v0.16.0 instead of tracking main.
  • Update the wget URL in the pages workflow to fetch singularity.def from the Palace v0.16.0 tag rather than the main branch.
  • Add an inline comment explaining the pinning rationale and noting this as a TODO for a future upgrade to the new build procedure.
  • Apply the same URL change and explanatory comment to the test_code workflow so both CI jobs use the pinned Singularity definition.
.github/workflows/pages.yml
.github/workflows/test_code.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider extracting the pinned Palace version into a single workflow-level env/variable so both workflows reference the same value and it’s easier to bump in one place later.
  • Since this is intended as a temporary workaround, it may help to add a short comment with a link to the upstream Palace change or issue so future maintainers know what needs to be updated when switching to the new build procedure.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider extracting the pinned Palace version into a single workflow-level env/variable so both workflows reference the same value and it’s easier to bump in one place later.
- Since this is intended as a temporary workaround, it may help to add a short comment with a link to the upstream Palace change or issue so future maintainers know what needs to be updated when switching to the new build procedure.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@joamatab joamatab merged commit b5f5483 into gdsfactory:main Apr 28, 2026
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants