Temporary fix of the palace CI#700
Merged
Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideTemporarily pins the Palace Singularity definition URL in CI workflows to a known-good tagged release (v0.16.0) so that GitHub Actions continue to build and test against a valid Singularity definition despite upstream deprecation. Sequence diagram for GitHub Actions job using pinned Palace Singularity definitionsequenceDiagram
participant GH as GitHub_Actions
participant Job as Pages_Workflow_Job
participant Runner as Ubuntu_Runner
participant Palace as Palace_GitHub_Repo
participant Cache as Actions_Cache
GH->>Job: Trigger pages workflow
Job->>Runner: Start job build_pages
Runner->>Runner: Install libglu1-mesa via apt-get
Runner->>Palace: HTTP GET /awslabs/palace/refs/tags/v0.16.0/singularity/singularity.def
Palace-->>Runner: 200 OK singularity.def
Runner->>Runner: Save singularity.def locally
Runner->>Cache: Restore cache key palace_container
Cache-->>Runner: Cache hit or miss
Runner->>Runner: Build Palace container using singularity.def
Runner->>Cache: Save updated palace_container cache
Runner-->>Job: Job completed
Job-->>GH: Report success
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider extracting the pinned Palace version into a single workflow-level env/variable so both workflows reference the same value and it’s easier to bump in one place later.
- Since this is intended as a temporary workaround, it may help to add a short comment with a link to the upstream Palace change or issue so future maintainers know what needs to be updated when switching to the new build procedure.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider extracting the pinned Palace version into a single workflow-level env/variable so both workflows reference the same value and it’s easier to bump in one place later.
- Since this is intended as a temporary workaround, it may help to add a short comment with a link to the upstream Palace change or issue so future maintainers know what needs to be updated when switching to the new build procedure.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
joamatab
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As of Palace
v0.16.1, building palace fromsingularity.defis no longer supported.This PR is a temporary fix that pins the version of the repository to
v0.16.0in the GitHub action workflow to prevent the HTTP error.A more permanant fix would involve using the newer build procedure.
Related issue
Addresses #699
Summary by Sourcery
CI: