Scintilla, SCI_MARKERNEXT or SCI_INDICATORSTART: right recipe for GeanyLua

[Skif-off]

Please, help needed: I guess, I'm missing something obvious, but I haven't figured out what it is yet.

I tried to set bookmark for each line with marked text (after "Mark All" or related button in the Find dialog):

-- Marker mask: GEANY_INDICATOR_SEARCH = 8, so "mask = 1 << 8" or "1 * 2 ^ 8"
local iM = 0x100

-- SCI_MARKERGET
if geany.scintilla(2046, 0, 8) ~= 0 then
  -- SCI_MARKERADD
  geany.scintilla(2043, 0, 1)
end
local n1, n2
n2 = 0
while true do
  -- SCI_MARKERNEXT
  n1 = geany.scintilla(2047, n2 + 1, iM)
  if n1 == -1 then break end
  -- SCI_MARKERADD
  geany.scintilla(2043, n1, 1)
  n2 = n1
end

This script didn't work, so I tried another way:

local n1, n2, n3
n2 = 0
while true do
  -- SCI_INDICATORSTART
  n1 = geany.scintilla(2508, 8, n2)
  if n1 == -1 then break end
  -- SCI_LINEFROMPOSITION
  n3 = geany.scintilla(2166, n1, 0)
  -- SCI_MARKERADD
  geany.scintilla(2043, n3, 0)
  n2 = n1 + 1
end

but didn't work too.
Any ideas?

Edit:
Fix geany.scintilla(2043, n3, 0) in the second variant (0 -> 1).

[Skif-off]

Also

-- SCI_GETLENGTH
local iL = geany.scintilla(2006, 0, 0)
local n1, n2, n3
n2 = 0
while true do
  -- SCI_INDICATORVALUEAT
  n1 = geany.scintilla(2507, 8, n2)
  if n1 ~= 0 then
    -- SCI_LINEFROMPOSITION
    n3 = geany.scintilla(2166, n1, 0)
    -- SCI_MARKERADD
    geany.scintilla(2043, n3, 1)
    -- SCI_GETLINEENDPOSITION
    n2 = geany.scintilla(2136, n3, 0)
  end
  n2 = n2 + 1
  if n2 >= iL then break end
end

didn't work.

[kupernikus87]

Here is the English version of the explanation and the corrected script, ready for you to share with the community or the original author.

Why the Original Script Failed (Infinite Loop)
Scintilla indicators work with values. When there is no search hit at a text position, the indicator value there is 0. If you call SCI_INDICATORSTART at an unmarked position, Scintilla looks for the start of the continuous range that shares that same value (which is 0).

So, if you are at position n2 = 10 and there is no highlight, SCI_INDICATORSTART will jump all the way back to 0 (the beginning of the file where the text is also unmarked). This resets your n1 to 0, making n2 become 1 in the next iteration, trapping the script in an infinite loop.

The Solution: Using SCI_INDICATOREND (2509)
To reliably step through the search results, you need a combination of SCI_INDICATORVALUEAT (2507) (to check if a highlight exists at the current position) and SCI_INDICATOREND (2509) (to jump to the next state transition).

When you call SCI_INDICATOREND while sitting on an unmarked region, Scintilla automatically fast-forwards to the start of the next actual highlight.

Here is the corrected and working Lua script:

Lua

local pos = 0
local doc_length = geany.scintilla(2006, 0, 0) -- SCI_GETLENGTH: Total document length

while pos < doc_length do
  -- 2507 = SCI_INDICATORVALUEAT: Check if the search indicator (8) is active at 'pos' (> 0)
  if geany.scintilla(2507, 8, pos) > 0 then
    
    -- 2166 = SCI_LINEFROMPOSITION: Get the line number from the character position
    local line = geany.scintilla(2166, pos, 0)
    
    -- 2043 = SCI_MARKERADD: Add a bookmark to this line
    -- Note: Geany uses Scintilla marker 0 for its standard native bookmarks
    geany.scintilla(2043, line, 0)
    
    -- Jump to the end of this highlighted text block
    local next_pos = geany.scintilla(2509, 8, pos) -- SCI_INDICATOREND
    if next_pos <= pos then break end -- Safety brake against infinite loops
    pos = next_pos
  else
    -- If there is no highlight here, jump to the end of the unhighlighted block
    -- (= the exact starting point of the next search hit!)
    local next_pos = geany.scintilla(2509, 8, pos) -- SCI_INDICATOREND
    if next_pos <= pos then break end
    pos = next_pos
  end
end

Try this hope will help

[Skif-off]

I also wrote this version:

-- SCI_GETLENGTH
local iL = geany.scintilla(2006, 0, 0)
local n1, n2
n1 = 0
while true do
  -- SCI_INDICATORVALUEAT
  if geany.scintilla(2507, 8, n1) > 0 then
    -- SCI_LINEFROMPOSITION
    n2 = geany.scintilla(2166, n1, 0)
    -- SCI_MARKERADD
    geany.scintilla(2043, n2, 1)
    -- SCI_GETLINEENDPOSITION
    n1 = geany.scintilla(2136, n2, 0)
  end
  n1 = n1 + 1
  if n1 > iL then break end
end

and this version started working.

@kupernikus87
Thanks! I made this version

-- SCI_GETLENGTH
local iL = geany.scintilla(2006, 0, 0)
local n1, n2, n3
n1 = 0
while true do
  -- SCI_INDICATORVALUEAT
  if geany.scintilla(2507, 8, n1) > 0 then
    -- SCI_LINEFROMPOSITION
    n3 = geany.scintilla(2166, n1, 0)
    -- SCI_MARKERADD
    geany.scintilla(2043, n3, 1)
    -- SCI_INDICATOREND
    n2 = geany.scintilla(2509, 8, n1)
  else
    -- SCI_INDICATOREND
    n2 = geany.scintilla(2509, 8, n1)
  end
  if n2 <= n1 then break end
  n1 = n2
  if n1 > iL then break end
end

I tested both with a large number of bookmarks (~1600-1700) with a plain text file (i.e. without syntax highlighting) and the second script works significantly faster (in this case, approximately five times faster).

It is still unclear why SCI_MARKERNEXT does not work with GEANY_INDICATOR_SEARCH?
(GEANY_INDICATOR_SEARCH = 8 = INDIC_CONTAINER.)

P.S.

Note: Geany uses Scintilla marker 0 for its standard native bookmarks

For commands like "Mark" and "Go to * marker" Geany uses marker 1.