worked on question2 #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulexcel01
suggested changes
Nov 9, 2023
| const bcrypt = require("bcryptjs"); | ||
| const jwt = require("jsonwebtoken"); | ||
| const {updateuser1,getdata,matchpass,modifyPass,verifyemail,userlogin,usersignup,user_list} = require("../services/userservices") | ||
| const {updateuser1,getdata,useraddress,matchpass,modifyPass,verifyemail,userlogin,usersignup,user_list} = require("../services/userservices") |
There was a problem hiding this comment.
use classes or object and keep everything inside it a lot of import like this doesn't look good
| const userModel = require("./userModel"); | ||
| const user = mongoose.Schema({ | ||
| user_id:{ | ||
| type:'ObjectId', |
There was a problem hiding this comment.
createdat and updated At field should be there
| router.use('/updateuser',mid_register.checkAuth) | ||
| router.use('/get',mid_register.checkAuth) | ||
| router.use('/delete',mid_register.checkAuth) | ||
| router.use('/address',mid_register.checkAuth) |
There was a problem hiding this comment.
move middleware in separate file instead route
| pin_code: data.pin_code, | ||
| phone: data.phone | ||
| }); | ||
| if(user){ |
There was a problem hiding this comment.
why are you checking user here ? you need to verify data
|
|
||
| exports.checkAuth = async (req, res, next) => { | ||
| const bearerHeader = req.headers["authorization"]; | ||
| if (typeof bearerHeader !== "undefined") { |
There was a problem hiding this comment.
improve else if conditions here doesn't look good here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.