Skip to content

Update some comments #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2020
Merged

Update some comments #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions src/robot.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
* @file robot.cpp
* @author José Ángel Sánchez (https://github.com/gelanchez)
* @brief Library for controling the robot.
* @version 1.0.0
* @date 2020-08-22
* @version 1.0.1
* @date 2020-08-23
* @copyright GPL-3.0
*/

Expand All @@ -22,14 +22,6 @@ m_previousAngle{ 90 }, m_interval{ Constants::updateInterval },
m_sonarMap{ Constants::maxDistance, Constants::maxDistance, Constants::maxDistance, Constants::maxDistance, Constants::maxDistance }
{
m_lastUpdate = millis();
// m_motors = Motors();
// m_servo = MyServo(); // do NOT attach the pin here but in begin
// m_ultrasonic = Ultrasonic();
// m_lineTracking = LineTraking();
// m_sonarMap{Constants::maxDistance, Constants::maxDistance, Constants::maxDistance, Constants::maxDistance, Constants::maxDistance};
// m_state = RobotModeState::START; // Initial state of the RobotMode
// m_previousAngle = 90; // Previous angle of the servo, initial value
// m_interval = Constants::defaultInterval;
}

RobotControl::~RobotControl()
Expand Down Expand Up @@ -298,7 +290,7 @@ void RobotControl::lineTrackingMode()
m_motors.stop();
}
break;
case RobotModeState::ROTATE: // Totate 90 deg
case RobotModeState::ROTATE: // Rotate 90 deg
if ((millis() - m_lastUpdate) >= Constants::rotate90Time)
{
m_motors.stop();
Expand Down