This repository was archived by the owner on Sep 21, 2022. It is now read-only.
fix(coverage): support webpack sourcemaps format #855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DudaGod
suggested changes
Dec 20, 2017
Member
DudaGod
left a comment
DudaGod
left a comment
There was a problem hiding this comment.
fix this please and we will merge it
lib/coverage.js
Outdated
| var base64Prefix = 'data:application/json;base64,'; | ||
| if (_.includes(sourceMapUrl, base64Prefix)) { | ||
| var base64Str = sourceMapUrl.split(base64Prefix)[1], | ||
| var base64Prefix = /^data:application\/json;(charset=utf-8;)?base64,/; |
Member
There was a problem hiding this comment.
we don't need to use capturing brackets here:
var base64Prefix = /^data:application\/json;(?:charset=utf-8;)?base64,/;
ftdebugger
force-pushed
the
bugfix/webpack-coverage
branch
from
4a6412f to
1794e13
Compare
Contributor
Author
|
Done |
Member
|
thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.