Skip to content

Conversation

@gemmadanks
Copy link
Owner

@gemmadanks gemmadanks commented Dec 8, 2025

What changes did you make (give an overview)?

  • Added tests for notebooks
  • Fixed bug in example notebook
  • Added just command for starting Jupyter from the devcontainer
  • Updated documentation

Prerequisites checklist

Please check each of the following before merging:

  • This pull request is ready to merge (leave unchecked to indicate a WIP)
  • I will squash my commits and, where needed, edit the commit messages to make them more informative and follow the conventional commits format
  • I have updated relevant documentation
  • I have linked to relevant issues
  • I have created an ADR (Architectural Decision Record) for architecturally significant changes

What is the purpose of this pull request?

Check all that apply:

  • Documentation update
  • Changes to dependencies
  • Refactor
  • Improved tests
  • Improved CI
  • Bug fix
  • Changes to an existing feature
  • New feature
  • Other, please explain:

Copilot AI review requested due to automatic review settings December 8, 2025 20:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive testing support for Jupyter notebooks in the project. It fixes an import bug in the example notebook, adds infrastructure for running notebook tests using nbmake, and improves developer experience with new just commands and updated documentation.

Key Changes:

  • Added nbmake dependency and test command for automated notebook testing
  • Fixed incorrect function import in the example notebook (greet → say_hello)
  • Added Jupyter lab command for running notebooks in devcontainers

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

File Description
pyproject.toml Added nbmake dependency for notebook testing
notebooks/example.ipynb Fixed function import bug and corrected cell type for markdown heading
justfile Added test-notebooks and jupyter-devcontainer commands
README.md Updated documentation with new test command and fixed package rename instruction

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@gemmadanks gemmadanks merged commit 201e982 into main Dec 8, 2025
33 checks passed
@gemmadanks gemmadanks deleted the feat-notebook-tests branch December 8, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants