Skip to content

Use a static packet buffer in DMXConnection #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use a static packet buffer in DMXConnection #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions pyenttec/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,14 +137,29 @@ def __init__(self, com_port=None, univ_size=_MAX_DMX_SIZE):
raise EnttecConfigError("Illegal universe size {}; min is {}."
.format(univ_size, _MIN_DMX_SIZE))

# need to add a pad byte to the serial packet before the DMX payload
packet_start = (_START_VAL,
PortActions.SendDMXPacket,
(univ_size + 1) & 0xFF,
( (univ_size + 1) >> 8) & 0xFF,
0)
packet_start = array('B', packet_start).tobytes()

a, b, c = len(packet_start), univ_size, len(_PACKET_END)

self._packet = memoryview(array('B', b'\x00' * (a + b + c)))

self._packet[:a] = packet_start
self.dmx_frame = self._packet[a:a + b]
self._packet[a + b:] = _PACKET_END

self._port_params = EnttecProParams()
self.dmx_frame = array('B', b'\x00' * univ_size)
self._com_port = com_port

self.com = None
self._open_port()

self._update_params()
self._write_settings()

def _open_port(self):
try:
Expand Down Expand Up @@ -172,28 +187,13 @@ def set_refresh_rate(self, refresh_rate):
self._port_params.refresh_rate = refresh_rate
self._write_settings()

def _update_params(self):
"""Recompute all of the port parameters and update the port settings."""
univ_size = len(self.dmx_frame)

# need to add a pad byte to the serial packet before the DMX payload
packet_start = (_START_VAL,
PortActions.SendDMXPacket,
(univ_size + 1) & 0xFF,
( (univ_size + 1) >> 8) & 0xFF,
0)
self._packet_start = array('B', packet_start).tobytes()

self._write_settings()

def _write_settings(self):
"""Write the current settings to the port."""
self.com.write(self._port_params.to_packet())

def render(self):
"""Write the current DMX frame to the port."""

self.com.write(self._packet_start + self.dmx_frame.tobytes() + _PACKET_END)
self.com.write(self._packet)

def set_channel(self, chan, val):
"""Set the value of a DMX channel, indexed from 0.
Expand Down