Skip to content

Conversation

@yelkurdi
Copy link
Contributor

@yelkurdi yelkurdi commented Sep 15, 2025

Adds feature for majority voting sampling strategy

  • Majority voting sampling strategy inherits from RejectionSamplingStrategy class.
  • Majority voting runs on top of Mellea's sampling design, which means it supports requirements, verifiers, repairs up to an extent compatible with majority voting
  • Majority voting using math_verify for math related tasks
  • MBRD (Minimum Bayes Risk Decoding) using rougeL similarity for general generations
  • requires adding async PR: feat: add async and streaming #137

@mergify
Copy link

mergify bot commented Sep 15, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|release)(?:\(.+\))?:

@yelkurdi yelkurdi marked this pull request as draft September 15, 2025 14:16
@yelkurdi yelkurdi marked this pull request as ready for review September 18, 2025 17:28
@yelkurdi yelkurdi marked this pull request as draft September 18, 2025 19:25
@nrfulton nrfulton self-requested a review September 22, 2025 14:46
@yelkurdi yelkurdi marked this pull request as ready for review September 25, 2025 21:57
@yelkurdi
Copy link
Contributor Author

@nrfulton should be ready for review.

  • I've merged the latest main branch with support for asynchronous sampling calls.
  • Majority Voting now supports concurrent asynchronous calls
  • Test function fixed and supports default Ollama server

To execute the test:

uv run --with mellea test/stdlib_basics/test_majority_voting.py

Copy link
Contributor

@jakelorocco jakelorocco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make sure to run the pre-commits on this PR to avoid any issues. The key changes look good. Thank you for writing the tests as well.

@jakelorocco jakelorocco merged commit 36eaca4 into generative-computing:main Oct 3, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants