-
Notifications
You must be signed in to change notification settings - Fork 49
feat: majority voting sampling strategy #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: majority voting sampling strategy #142
Conversation
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
…rt concurrent asynchronous sampling
|
@nrfulton should be ready for review.
To execute the test: |
…in devirved classes
Upgraded code to match new refactoring
jakelorocco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make sure to run the pre-commits on this PR to avoid any issues. The key changes look good. Thank you for writing the tests as well.
Adds feature for majority voting sampling strategy
math_verifyfor math related tasksrougeLsimilarity for general generations