Skip to content

Conversation

@jakelorocco
Copy link
Contributor

Fixes docstrings for mellea/; doesn't fix for cli/ and docs/

I re-enabled the docstring rules for the ruff linter. It isn't as strict in many ways. I also checked for additional arguments (args that were in the docstring but not the function) using pydoclint.

pydoclint reports a lot of additional issues (like a lack of types, etc...). Unfortunately, it doesn't look like there's tools to add type hints to already existing docstrings.

We should define how strict we want to be going forward and see if ruff can enforce that. If not, it might be worth having an additional pydoclint check:

  • all docstrings require args and return sections
  • all docstrings require type hints
  • either the class or init method should have a docstring, not both (for some reason ruff forces both to have docstrings)
  • docstrings must have raises sections
  • etc...

@jakelorocco jakelorocco changed the title fix docstrings fix: docstrings Oct 2, 2025
@mergify
Copy link

mergify bot commented Oct 2, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|release)(?:\(.+\))?:

@jakelorocco jakelorocco requested review from HendrikStrobelt and nrfulton and removed request for HendrikStrobelt October 2, 2025 20:18
@HendrikStrobelt
Copy link
Contributor

approved via slack

@HendrikStrobelt HendrikStrobelt merged commit 6126bd9 into main Oct 2, 2025
4 checks passed
@HendrikStrobelt HendrikStrobelt deleted the jal/fix-docstrings branch October 2, 2025 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants