fix: fix vllm install script #185
Merged
+31
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
jakelorocco
force-pushed
the
jal/vllm-fix
branch
from
de7efeb to
7857a9f
Compare
jakelorocco
force-pushed
the
jal/vllm-fix
branch
from
b631564 to
8737c7f
Compare
jakelorocco
requested review from
guicho271828
and removed request for
avinash2692
Contributor
Author
|
@guicho271828 can you please take a look at my changes to the install script? |
Contributor
Author
|
Approved; |
tuliocoppola
pushed a commit
to tuliocoppola/mellea
that referenced
this pull request
Nov 5, 2025
* fix: fix vllm install script * fix: branch selection * fix: fix pytest install in vllm script * fix: update openai alora tests * fix: test and params for openai constraint alora * test: debugging info * fix: kill zombie vllm process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VLLM install script now gets the latest shared commit between the main vllm repo and the alora fork so that updates to the alora fork don't cause issues.
Added a check after the tests run to kill a VLLM zombie process that causes issues.
Updated the vllm alora tests, fixed bugs in the vllm alora processing code, and ensured tests run.
Script runs and tests pass.