Skip to content

feat: add codeowners for the granite-common part of mellea intrinsics#669

Merged
jakelorocco merged 2 commits intomainfrom
jal/intrinsics-codeowners
Mar 17, 2026
Merged

feat: add codeowners for the granite-common part of mellea intrinsics#669
jakelorocco merged 2 commits intomainfrom
jal/intrinsics-codeowners

Conversation

@jakelorocco
Copy link
Copy Markdown
Contributor

@jakelorocco jakelorocco commented Mar 17, 2026

Misc PR

Type of PR

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Description

  • Link to Issue: Fixes N/A

Now that granite common is a part of Mellea, there are portions of the code that are best owned by the team that heads that work. I've created a new team mellea-intrinsics to delegate responsibility to. If this restriction becomes too burdensome, we can remove this; it's main goal is to notify those contributors when a change is going in / needs to be reviewed.

Testing

  • Tests added to the respective file if code was changed
  • New code has 100% coverage if code as added
  • Ensure existing tests and github automation passes (a maintainer will kick off the github automation when the rest of the PR is populated)

@github-actions
Copy link
Copy Markdown
Contributor

The PR description has been updated. Please fill out the template for your PR to be reviewed.

@jakelorocco jakelorocco marked this pull request as ready for review March 17, 2026 17:27
@jakelorocco jakelorocco requested a review from a team as a code owner March 17, 2026 17:27
@jakelorocco
Copy link
Copy Markdown
Contributor Author

@psschwei, when you have a moment, could you please take a look at this and make sure I got the syntax correct? The goal here is to allow @frreiss (and potentially others in the future) be able to add test to the parts of Mellea intrinsics that were initially granite-common.

Copy link
Copy Markdown
Member

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
If we ever have trivial things we need to merge in those directories, an admin should be able to override (meaning we wouldn't be blocked on needing someone from the intrinsics team to review)

@jakelorocco jakelorocco changed the title feat: add codeowners specifically for the granite-common part of mellea intrinsics feat: add codeowners for the granite-common part of mellea intrinsics Mar 17, 2026
@jakelorocco jakelorocco enabled auto-merge March 17, 2026 18:49
@jakelorocco jakelorocco disabled auto-merge March 17, 2026 19:36
@jakelorocco jakelorocco enabled auto-merge March 17, 2026 19:36
@jakelorocco jakelorocco added this pull request to the merge queue Mar 17, 2026
Merged via the queue into main with commit a4ec484 Mar 17, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants