add fixes to a few tests that were consistently failing; add support for granite 3.3 constraint alora #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few tests were consistently failing even though the code was executing correctly. I've updated the tests to fix that.
One notable change here is the addition of a Granite 3.3 Alora. While testing the failing hugging face test for the granite constraint alora, it was suggested that part of the issue might be that the 3.2 alora is generally worse than the 3.3 alora, especially because the output that our alora was running against contained unclosed quotes and punctuation that may have been impacting what the alora generated.
Ultimately, it looks like 3.3 still struggles with that as well (even with it's new syntax). But I had already implemented most of the changes, so I kept that.
To fix the failed test, I just ensured the test generated a smaller output that wasn't abruptly ended.
End result: