Skip to content

Do not call flushBuffers on exitApplication if object does not have batchCursors #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2021
Merged

Do not call flushBuffers on exitApplication if object does not have batchCursors #330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bff317a
Do not call flushBuffers on exitApplication if object does not have b…
claudiamurialdo Apr 9, 2021
062f30d
Do not call flushBuffers on exitApplication if object does not have b…
claudiamurialdo Apr 9, 2021
413e565
Merge branch 'master' into ExitApplicationFlushBatchCursors
claudiamurialdo Apr 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions dotnet/src/dotnetframework/GxClasses/Middleware/GXHttp.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1322,8 +1322,7 @@ public string StaticContentBase
set { staticContentBase = value; }

}

protected void exitApplication()
protected void ExitApp()
{
if (disconnectUserAtCleanup)
{
Expand All @@ -1333,7 +1332,11 @@ protected void exitApplication()
}
catch (Exception) {; }
}
}

protected void exitApplication()
{
ExitApp();
}

private bool IsGxAjaxRequest()
Expand Down
17 changes: 14 additions & 3 deletions dotnet/src/dotnetframework/GxClasses/Model/gxproc.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,21 @@ public static WaitCallback PropagateCulture(WaitCallback action)
action(x);
};
}
protected void ExitApp()
{
exitApplication(BatchCursorHolder());
}
protected void exitApplication()
{
foreach (IGxDataStore ds in context.DataStores)
ds.Connection.FlushBatchCursors(this);
exitApplication(true);
}
private void exitApplication(bool flushBatchCursor)
{
if (flushBatchCursor)
{
foreach (IGxDataStore ds in context.DataStores)
ds.Connection.FlushBatchCursors(this);
}

if (IsMain)
dbgInfo?.OnExit();
Expand All @@ -103,7 +114,7 @@ protected void exitApplication()
#endif

}

protected virtual bool BatchCursorHolder() { return false; }
protected virtual void printHeaders(){}
protected virtual void printFooters(){}

Expand Down