Wait for submitted threads to end before terminating a command line procedure #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Cherry pick to beta success |
iroqueta
reviewed
Sep 10, 2021
Contributor
iroqueta
left a comment
iroqueta
left a comment
There was a problem hiding this comment.
In the WaitForThreadPoolEnd routine it seems that the SetMaxThreads method call that is outside the loop is unnecessary
Collaborator
Author
You mean ThreadPool.GetMaxThreads right?. It is necessary to get the maxWorkerThreads value used inside the loop. |
iroqueta
approved these changes
Sep 10, 2021
claudiamurialdo
added a commit
that referenced
this pull request
Sep 15, 2021
claudiamurialdo
added a commit
that referenced
this pull request
Mar 31, 2022
…y the threads started by a Submit call type. It does not wait for other threads to finish (like the ones started by aspnet thread pool).
claudiamurialdo
added a commit
that referenced
this pull request
Apr 26, 2022
…rocedure - new implementation (#580) * Re-implement PR #446 with a new solution which takes into account only the threads started by a Submit call type. It does not wait for other threads to finish (like the ones started by aspnet thread pool). * Clear events after WaitAll ending. * Add log message to submit waiting routine. * Add unit test for submit function. Take into account limitation of WaitHandle.WaitAll and 64 threads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:24006