Add a converter to serialize properly DBNull value #477
Conversation
…he suggestion in dotnet/runtime#418 Move duplicate code in GxRedis.cs and GxMemcached.cs to GxClasses.csproj Adding the package reference System.Text.Json to GxClasses.csproj gets a conflict with System.Net.Http. Because of that, HttpClient used in MapFunctions.cs is replaced by HttpWebRequest for .netframework similar to the use in GXGeolocation.
Cherry pick to beta success |
claudiamurialdo
changed the title
| #if !NETCORE | ||
| HttpWebRequest req = (HttpWebRequest)WebRequest.Create(new Uri(urlString)); | ||
| req.Method = "GET"; | ||
| HttpWebResponse resp = (HttpWebResponse)req.GetResponse(); |
There was a problem hiding this comment.
HttpWebResponse should be released. Maybe include "using" ?
https://docs.microsoft.com/en-us/dotnet/api/system.net.httpwebresponse.getresponsestream?view=net-5.0
There was a problem hiding this comment.
You are right. Moreover, I removed the unused code.
| { | ||
| string info = readStream.ReadToEnd(); | ||
| } | ||
| rStream.Close(); |
There was a problem hiding this comment.
Why not use "using" instead of .Close() ?
There was a problem hiding this comment.
Definitely. The unnecessary code was removed.
| { | ||
| using (HttpContent content = response.Content) | ||
| { | ||
| string info = content.ReadAsStringAsync().Result; |
There was a problem hiding this comment.
I know this is not part of this commit, sorry!. But look what weird it is this.
The Web Response "info" string is read from the Stream, but not used anywhere?
Also, if the HttpRequest fails (crashes), Exception would ocurr. Maybe we can add a try-catch and log the error? What do you think?
There was a problem hiding this comment.
No doubt about it. I removed that unnecessary code.
…abs/DotNetClasses into memcached-serialization
Cherry pick to beta success |
* Add a converter to serialize properly the DBNull value according to the suggestion in dotnet/runtime#418 Move duplicate code in GxRedis.cs and GxMemcached.cs to GxClasses.csproj Adding the package reference System.Text.Json to GxClasses.csproj gets a conflict with System.Net.Http. Because of that, HttpClient used in MapFunctions.cs is replaced by HttpWebRequest for .netframework similar to the use in GXGeolocation. * Remove unused code. (cherry picked from commit fbfe50c)
According to the suggestion at dotnet/runtime#418
Issue:91913
Move duplicate code in GxRedis.cs and GxMemcached.cs to GxClasses.csproj
Adding the package reference System.Text.Json to GxClasses.csproj gets a conflict with System.Net.Http. Because of that, HttpClient used in MapFunctions.cs is replaced by HttpWebRequest for .netframework similar to the use in GXGeolocation.