Content-Disposition filename gets garbled filename for Japanese Characters in Safari.

[ggallotti]

This code :
&HttpResponse.AddHeader(!"Content-Disposition", !'attachment; filename=注文詳細.xlsx')

Gets garbled http download filename in Safari.

Change log:

• We now use RFC5987 " Character Set and Language Encoding for Hypertext Transfer Protocol (HTTP) Header Field Parameters" for encoding filename attribute inside Content-Disposition Header. We fallback to the original method when somethig fails.
• Safari does not support RFC5987 nor String encoded Filename atribute, so we disable encoding for this Browser until RFC5987 get supported.

[genexusbot]

Cherry pick to beta failed, 1 conflicted file in commit fd71286

• dotnet/src/dotnetframework/GxClasses/Helpers/HttpHelper.cs

[claudiamurialdo]

Could GetEncodedContentDisposition be internal instead of public?

[ggallotti]

Could GetEncodedContentDisposition be internal instead of public?

If I change to internal, UnitTest Project fails to compile. What do you suggest?

[genexusbot]

Cherry pick to beta failed, 1 conflicted file in commit fd71286

• dotnet/src/dotnetframework/GxClasses/Helpers/HttpHelper.cs

[claudiamurialdo]

Could GetEncodedContentDisposition be internal instead of public?

If I change to internal, UnitTest Project fails to compile. What do you suggest?

Try adding
[assembly: InternalsVisibleTo("DotNetCoreUnitTest")]

to AssemblyInfo.cs of GxClasses.dll

[genexusbot]

Cherry pick to beta failed, 3 conflicted files in commit fd71286

• dotnet/src/dotnetframework/GxClasses/Core/Web/GxHttpServer.cs
• dotnet/src/dotnetframework/GxClasses/Helpers/HttpHelper.cs
• dotnet/test/DotNetCoreUnitTest/HttpUtils/HttpUtils.cs

[ggallotti]

@claudiamurialdo : This is ready to review. Thanks!