Skip to content

Session recovery after an application encryption key renewal was not working in .NET. #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2022
Merged

Session recovery after an application encryption key renewal was not working in .NET. #707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
986ddba
Session recovery after an application encryption key renewal was not …
claudiamurialdo Nov 3, 2022
8795d39
Remove unused using.
claudiamurialdo Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions dotnet/src/dotnetframework/GxClasses/Middleware/GXHttp.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1537,17 +1537,24 @@ protected void SendResponseStatus(HttpStatusCode statusCode)
SendResponseStatus((int)statusCode, string.Empty);
}


#if !NETCORE
protected void SendResponseStatus(int statusCode, string statusDescription)
{
context.HttpContext.Response.StatusCode = statusCode;
#if !NETCORE
if (!string.IsNullOrEmpty(statusDescription))
context.HttpContext.Response.StatusDescription = statusDescription;
#endif
this.setAjaxCallMode();
this.disableOutput();
}

#else
protected override void SendResponseStatus(int statusCode, string statusDescription)
{
context.HttpContext.Response.StatusCode = statusCode;
this.setAjaxCallMode();
this.disableOutput();
}
#endif
private void SendReferer()
{
context.httpAjaxContext.ajax_rsp_assign_hidden("sCallerURL", context.GetReferer());
Expand Down
10 changes: 9 additions & 1 deletion dotnet/src/dotnetframework/GxClasses/Model/GXBaseObject.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
using GeneXus.Diagnostics;
using GeneXus.Encryption;
using GeneXus.Http;
using GeneXus.Utils;
Expand Down Expand Up @@ -142,10 +141,17 @@ private string Encrypt64(string value, string key, bool safeEncoding)
}
catch (InvalidKeyException)
{
context.SetCookie("GX_SESSION_ID", string.Empty, string.Empty, DateTime.MinValue, string.Empty, context.GetHttpSecure());
GXLogging.Error(log, "440 Invalid encryption key");
SendResponseStatus(440, "Session timeout");
}
return sRet;
}
protected virtual void SendResponseStatus(int statusCode, string statusDescription)
{
context.HttpContext.Response.StatusCode = statusCode;
}

protected string UriEncrypt64(string value, string key)
{
return Encrypt64(value, key, true);
Expand All @@ -164,7 +170,9 @@ private string Decrypt64(string value, string key, bool safeEncoding)
}
catch (InvalidKeyException)
{
context.SetCookie("GX_SESSION_ID", string.Empty, string.Empty, DateTime.MinValue, string.Empty, context.GetHttpSecure());
GXLogging.Error(log, "440 Invalid encryption key");
SendResponseStatus(440, "Session timeout");
}
return sRet;
}
Expand Down