Skip to content

Bump TLS 1.0 to TLS1.2 for Apple Push Notifications #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Bump TLS 1.0 to TLS1.2 for Apple Push Notifications #766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dotnet/src/dotnetframework/SDNetAPI/IOSNotifications.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System;
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
Expand Down Expand Up @@ -177,7 +177,7 @@ private static bool DoCall(string server, string p12path, int port, Action<SslSt

try
{
sslStream.AuthenticateAsClient(server, clientCertificateCollection, SslProtocols.Tls, true);
sslStream.AuthenticateAsClient(server, clientCertificateCollection, SslProtocols.Tls12, true);
}
catch (Exception e)
{
Expand Down
3 changes: 1 addition & 2 deletions dotnet/src/dotnetframework/SDNetAPI/PushSharp/Platforms/Apple/ApplePushChannel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,8 +384,7 @@ void connect()

try
{
stream.AuthenticateAsClient(this.appleSettings.Host, this.certificates, System.Security.Authentication.SslProtocols.Tls, false);
//stream.AuthenticateAsClient(this.appleSettings.Host);
stream.AuthenticateAsClient(this.appleSettings.Host, this.certificates, System.Security.Authentication.SslProtocols.Tls12, false);
}
catch (System.Security.Authentication.AuthenticationException ex)
{
Expand Down
4 changes: 2 additions & 2 deletions dotnet/src/dotnetframework/SDNetAPI/PushSharp/Platforms/Apple/FeedbackService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System;
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
Expand Down Expand Up @@ -44,7 +44,7 @@ public void Run(ApplePushChannelSettings settings/*, CancellationToken cancelTok
(sender, cert, chain, sslErrs) => { return true; },
(sender, targetHost, localCerts, remoteCert, acceptableIssuers) => { return certificate; });

stream.AuthenticateAsClient(settings.FeedbackHost, certificates, System.Security.Authentication.SslProtocols.Tls, false);
stream.AuthenticateAsClient(settings.FeedbackHost, certificates, System.Security.Authentication.SslProtocols.Tls12, false);


//Set up
Expand Down