Print thread number instead of thread name at log4net logs. #787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tead of thread name in log messages. log4net uses thread name for pattern %thread when available, and it uses the thread number if no name is available. In .NET Framework and .NET until v5 threadpool threads are not named by default, therefore thread number is printed in traces by default, but in Net6 they are named. For tracing the thread number is more useful that thread name.
Collaborator
Cherry pick to beta success |
claudiamurialdo
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
ggallotti
previously approved these changes
Mar 21, 2023
Collaborator
Cherry pick to beta success |
claudiamurialdo
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
ggallotti
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log4net uses thread name for pattern %thread when available. It uses the thread number if no name is available.
In .NET Framework and .NET until v5 threadpool threads are not named by default, therefore thread number is printed in logs by default, but in Net6 they are named.
Given that the thread number is more useful that thread name, the property threadid is added to log4net context and can be used with the pattern [%property{threadid}]
Issue:101981