The css and js files that a UC use must have a invalidation token in … #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the URL, doing that the changes that the user do in the UC works without restarting the browser cache.
ncardeli
reviewed
Oct 10, 2019
Contributor
ncardeli
left a comment
ncardeli
left a comment
There was a problem hiding this comment.
Please consider my suggestion for checking if the URL is absolute.
|
|
||
| private String getURLBuildNumber(String styleSheet, String urlBuildNumber) | ||
| { | ||
| if(urlBuildNumber.isEmpty() && !((styleSheet.startsWith("http:")) || (styleSheet.startsWith("https:")))) |
Contributor
There was a problem hiding this comment.
How about using GXutil.isAbsoluteURL() method to check if the URL is absolute?
nicocard
approved these changes
Oct 11, 2019
ncardeli
approved these changes
Oct 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…the URL, doing that the changes that the user do in the UC works without restarting the browser cache.