Changed method to get cookies from context when executing as webapp #514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Cherry pick to beta success |
Collaborator
Cherry pick to beta success |
Collaborator
Cherry pick to beta success |
Collaborator
Cherry pick to beta success |
gmilano
reviewed
Jan 21, 2022
Contributor
gmilano
left a comment
gmilano
left a comment
There was a problem hiding this comment.
Actually I was expecting the other way around, leave the imports and remove the qualifiers to have more compact code.
| if (webcookie != null) | ||
| this.addHeader("Cookie", com.genexus.webpanels.WebUtils.decodeCookie(webcookie.getValue())); | ||
|
|
||
| String selfWebCookie = ((com.genexus.webpanels.HttpContextWeb) com.genexus.ModelContext.getModelContext().getHttpContext()).getCookie("Set-Cookie"); |
Contributor
There was a problem hiding this comment.
Improving coding style: When possible try to start reducing unnecesary qualifiers already included as imports.
In this case com.genexus.webpanels or com.genexus.
Contributor
There was a problem hiding this comment.
"Set-Cookie" "Cookie" please define static final String for them.
|
|
||
| String selfWebCookie = ((com.genexus.webpanels.HttpContextWeb) com.genexus.ModelContext.getModelContext().getHttpContext()).getCookie("Set-Cookie"); | ||
| if (!selfWebCookie.isEmpty()) | ||
| this.addHeader("Cookie", selfWebCookie.replace("+",";")); |
Contributor
There was a problem hiding this comment.
I couldn't understand what was failing in the previous code.
…nstants for Set-Cookie and Cookie
Collaborator
Cherry pick to beta failed, 1 conflicted file
|
gmilano
approved these changes
Jan 21, 2022
Collaborator
Cherry pick to beta failed, 1 conflicted file
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.