[AWS Serverless] Handle Referer Header special case #515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Cherry pick to beta success |
gmilano
approved these changes
Jan 21, 2022
| List<String> referer = awsProxyRequest.getMultiValueHeaders().get("Referer"); | ||
| if (referer != null && !referer.isEmpty()) { | ||
| awsProxyRequest.getMultiValueHeaders().put("GX-Referer", referer); | ||
| } |
Contributor
There was a problem hiding this comment.
And who is going to read the "GX-Referer" ?
Member
Author
There was a problem hiding this comment.
The Referer Header is required in Angular Applications to get the Query String of the original URL from the Server Side.
Due to AWS Lambda Jersey implementation, this Header is override by Lambda specific context.
We need to do a fork/clone or some class override in order to get the Referer Header working. In the meantime we are copying it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referer Header is not working on Lambda because the "Referer" Header is being override by Jersey Lambda Container implementation.
In the future we should clone, fork and publish a new Jersey Lambda Container implementation and remove this special behaviour, instead of copying the Header.
This was needed urgently for TikTok LigaMX Angular App.