Skip to content

Move try/catch to catch any error at parseInputJSonMessage function. #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 17, 2022
Merged

Move try/catch to catch any error at parseInputJSonMessage function. #542

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
075cb82
Move try/catch to catch any error at parseInputJSonMessage function.
claudiamurialdo Mar 14, 2022
0a73044
Catch JSONException when the json message is invalid.
claudiamurialdo Mar 17, 2022
fd1aeb8
Merge branch 'master' into ajax-json-parsing
claudiamurialdo Mar 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 38 additions & 46 deletions java/src/main/java/com/genexus/webpanels/GXWebPanel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,62 +514,55 @@ protected class DynAjaxEvent {
HashSet<String> inParmsMetadataHash;
boolean anyError;

private void parseInputJSonMessage(JSONObject objMessage, GXWebPanel targetObj) throws JSONException {
if (objMessage.has("parms"))
inParmsValues = objMessage.getJSONArray("parms");
if (objMessage.has("hsh"))
inHashValues = objMessage.getJSONArray("hsh");
if (objMessage.has("events"))
events = objMessage.getJSONArray("events");
if (objMessage.has("cmpCtx"))
cmpContext = objMessage.getString("cmpCtx");
this.targetObj = targetObj;
try
{
String pckgName = (objMessage.has("pkgName") && objMessage.getString("pkgName").length() > 0)? objMessage.getString("pkgName") + ".": "";
if (objMessage.has("MPage") && objMessage.getBoolean("MPage"))
{
if (objMessage.has("objClass"))
{
private void parseInputJSonMessage(String jsonMessage, GXWebPanel targetObj) throws JSONException {
try {
JSONObject objMessage = new JSONObject(jsonMessage);
if (objMessage.has("parms"))
inParmsValues = objMessage.getJSONArray("parms");
if (objMessage.has("hsh"))
inHashValues = objMessage.getJSONArray("hsh");
if (objMessage.has("events"))
events = objMessage.getJSONArray("events");
if (objMessage.has("cmpCtx"))
cmpContext = objMessage.getString("cmpCtx");
this.targetObj = targetObj;
String pckgName = (objMessage.has("pkgName") && objMessage.getString("pkgName").length() > 0) ? objMessage.getString("pkgName") + "." : "";
if (objMessage.has("MPage") && objMessage.getBoolean("MPage")) {
if (objMessage.has("objClass")) {
String fullClassName = pckgName + objMessage.getString("objClass") + "_impl";
Class<?> webComponentClass = targetObj.getClass().forName(fullClassName);
GXWebPanel webComponent = (GXWebPanel) webComponentClass.getConstructor(new Class<?>[] { int.class, ModelContext.class }).newInstance(new Object[] {new Integer(remoteHandle), context});
GXWebPanel webComponent = (GXWebPanel) webComponentClass.getConstructor(new Class<?>[]{int.class, ModelContext.class}).newInstance(new Object[]{new Integer(remoteHandle), context});
this.targetObj = webComponent;
}
}
else
{
if (!cmpContext.equals("") && objMessage.has("objClass"))
{
} else {
if (!cmpContext.equals("") && objMessage.has("objClass")) {
String fullClassName = pckgName + objMessage.getString("objClass") + "_impl";
GXWebComponent webComponent = WebUtils.getWebComponent(getClass(), fullClassName, remoteHandle, context);
this.targetObj = webComponent;
}
}
}
catch (Exception e)
{
if (objMessage.has("grids"))
parseGridsDataParms((JSONObject) objMessage.get("grids"));
if (objMessage.has("grid"))
grid = objMessage.getInt("grid");
else
grid = 0;
if (objMessage.has("row"))
row = objMessage.getString("row");
else
row = "";
if (objMessage.has("pRow"))
pRow = objMessage.getString("pRow");
if (objMessage.has("gxstate")) {
parseGXStateParms(objMessage.getJSONObject("gxstate"));
}
if (objMessage.has("fullPost")) {
parseGXStateParms(objMessage.getJSONObject("fullPost"));
}
} catch (Exception e) {
e.printStackTrace();
this.targetObj = new GXWebComponentNull(remoteHandle, context);
}
if (objMessage.has("grids"))
parseGridsDataParms((JSONObject)objMessage.get("grids"));
if (objMessage.has("grid"))
grid = objMessage.getInt("grid");
else
grid = 0;
if (objMessage.has("row"))
row = objMessage.getString("row");
else
row = "";
if (objMessage.has("pRow"))
pRow = objMessage.getString("pRow");
if (objMessage.has("gxstate")) {
parseGXStateParms(objMessage.getJSONObject("gxstate"));
}
if (objMessage.has("fullPost")) {
parseGXStateParms(objMessage.getJSONObject("fullPost"));
}
}

private void parseGridsDataParms(JSONObject gxGrids)
Expand Down Expand Up @@ -1101,8 +1094,7 @@ private void doInvoke(Object [] MethodParms) throws IllegalArgumentException,

public String invoke(String JsonMessage, GXWebPanel targetObj)
throws Exception {
JSONObject objMessage = new JSONObject(JsonMessage);
parseInputJSonMessage(objMessage, targetObj);
parseInputJSonMessage(JsonMessage, targetObj);
this.targetObj.setFullAjaxMode();
this.targetObj.createObjects();
this.targetObj.initialize();
Expand Down