Skip to content

Image API External Storage Support #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Apr 1, 2022
Merged

Image API External Storage Support #554

merged 14 commits into from
Apr 1, 2022

Conversation

@ggallotti
Copy link
Member

@ggallotti ggallotti commented Apr 1, 2022

Image Manipulation API now supports reading from Stream instead of Single Local File.

  • ImageHeight
  • ImageSize
  • ImageWidth
  • Scale()
  • Rotate()
  • Crop()

Added UnitTesting for GXTest And JUnit

Issue 94770

ggallotti added 14 commits April 1, 2022 09:23
@ggallotti
Support for ImageHeight and Width when Storage is Enabled
75b271e 
(cherry picked from commit 7be4e0e)
@ggallotti
Illigal Argument Exception catch
edaa87f 
(cherry picked from commit 96bef67)
@ggallotti
Support GetFileSize
38b611f 
(cherry picked from commit 92119c1)
@ggallotti
Crop, Resize, Scale, Rotate support for S3.
cc075c0 
(cherry picked from commit 8132c77)
@ggallotti
Remove unused code
a613b2e 
(cherry picked from commit 935af8c)
@ggallotti
Crop, Resize, Scale, Rotate support for S3.
2b0d026 
(cherry picked from commit b2005c7)
@ggallotti
Add UnitTests
df21f19 
(cherry picked from commit 414d246)
@ggallotti
GXFile should detect if it is already a absolute file path.
f4bcc12 
(cherry picked from commit 158099a)
@ggallotti
Fix
a615168
@ggallotti
Fix Code Quality
f4165d6 
(cherry picked from commit 58c42fc)
@ggallotti
Not working in some scenarios for external storage urls
cda9e34 
(cherry picked from commit 99da7fc)
@ggallotti
GxFile more defensive code
2d5e96f 
(cherry picked from commit c42979d)
@ggallotti
Compile fixes
4ad887a
@ggallotti
Compile error
4074658
@ggallotti ggallotti marked this pull request as ready for review April 1, 2022 13:19
@genexusbot
Copy link
Collaborator

genexusbot commented Apr 1, 2022

Cherry pick to beta failed, 1 conflicted file in commit 75b271e
  • java/src/main/java/com/genexus/GxImageUtil.java

@ggallotti ggallotti removed the conflict label Apr 1, 2022
@ggallotti ggallotti merged commit f5dd91f into release-2.2 Apr 1, 2022
@cinthamo
Copy link
Contributor

cinthamo commented Sep 4, 2024

Revert to beta failed, 1 conflicted file in commit 4074658
  • gxcloudstorage-tests/src/test/java/com/genexus/db/driver/TestExternalProvider.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bot closed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ggallotti @genexusbot @cinthamo