Skip to content

Redis connection did not support custom port #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 17, 2022
Merged

Redis connection did not support custom port #565

merged 11 commits into from
May 17, 2022

Conversation

@ggallotti
Copy link
Member

@ggallotti ggallotti commented May 12, 2022 •
edited by jechague
Loading

Redis connection string with custom port did not worked:
localhost:5858

  • Added UnitTesting in Github Actions to execute a real test using Redis Server with different connection scenarios.
  • Improved Jedis.GetResource handling.

Issue:96105

@ggallotti ggallotti marked this pull request as ready for review May 12, 2022 19:00
@ggallotti ggallotti requested a review from a team as a code owner May 12, 2022 19:00
@genexusbot
Copy link
Collaborator

genexusbot commented May 12, 2022

Cherry pick to beta success

@ggallotti ggallotti requested review from iroqueta and jechague May 13, 2022 13:42
@genexusbot
Copy link
Collaborator

genexusbot commented May 13, 2022

Cherry pick to beta success

iroqueta
iroqueta reviewed May 13, 2022
View reviewed changes
@genexusbot
Copy link
Collaborator

genexusbot commented May 13, 2022

Cherry pick to beta success

jechague
jechague approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@jechague jechague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New test workflow looks OK

@ggallotti ggallotti merged commit 2bc38d2 into master May 17, 2022
@ggallotti ggallotti deleted the redis-connect-urls branch May 17, 2022 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iroqueta iroqueta Awaiting requested review from iroqueta

@jechague jechague Awaiting requested review from jechague

Assignees

No one assigned

Labels

bot closed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ggallotti @genexusbot @jechague @iroqueta @cinthamo