Skip to content

ERR_CONTENT_DECODING_FAILED when Exception ocurrs on Server Side #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 17, 2022
Merged

ERR_CONTENT_DECODING_FAILED when Exception ocurrs on Server Side #577

merged 6 commits into from
Jun 17, 2022

Conversation

@ggallotti
Copy link
Member

@ggallotti ggallotti commented Jun 1, 2022 •
edited
Loading

Issue: 81695

@genexusbot
Copy link
Collaborator

genexusbot commented Jun 1, 2022

Cherry pick to beta success

@ggallotti ggallotti requested a review from iroqueta June 1, 2022 20:09
iroqueta
iroqueta previously approved these changes Jun 1, 2022
View reviewed changes
@genexusbot
Copy link
Collaborator

genexusbot commented Jun 2, 2022

Cherry pick to beta success

@genexusbot
Copy link
Collaborator

genexusbot commented Jun 2, 2022

Cherry pick to beta success
  • a6ccebd (warning: no changes merged)

@genexusbot
Copy link
Collaborator

genexusbot commented Jun 2, 2022

Cherry pick to beta success

@ggallotti ggallotti requested a review from iroqueta June 15, 2022 13:10
iroqueta
iroqueta reviewed Jun 15, 2022
View reviewed changes
Copy link
Collaborator

@iroqueta iroqueta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.rfc-editor.org/rfc/rfc2616#section-3.5

This link say this, what do you tihnk?

identity
The default (identity) encoding; the use of no transformation
whatsoever. This content-coding is used only in the Accept-
Encoding header, and SHOULD NOT be used in the Content-Encoding
header.

@ggallotti
Copy link
Member Author

ggallotti commented Jun 15, 2022

@iroqueta
Yes, I understand that the identity value is not best solution. However I do not have any other way for clearing that Header (that was set initially). The Java API does not allow to delete a current header.
The only way is to prevent from being set at first time, which would requiere a mayor refactoring on how we output the Stream to the Client (and much more time consuming). I wanted to keep it as safe as possible for now.

@ggallotti ggallotti merged commit 3669301 into master Jun 17, 2022
@ggallotti ggallotti deleted the gzip-encoding-onerror branch June 17, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iroqueta iroqueta iroqueta approved these changes

Assignees

No one assigned

Labels

bot closed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ggallotti @genexusbot @iroqueta @cinthamo