Skip to content

Conversation

@ggallotti
Copy link
Member

This code :
&HttpResponse.AddHeader(!"Content-Disposition", !'attachment; filename=注文詳細.xlsx')

Gets garbled http download filename in Safari.

Change log:

  • We now use RFC5987 " Character Set and Language Encoding for Hypertext Transfer Protocol (HTTP) Header Field Parameters" for encoding filename attribute inside Content-Disposition Header. We fallback to the original method when somethig fails.
  • Safari does not support RFC5987 nor String encoded Filename atribute, so we disable encoding for this Browser until RFC5987 get supported.

@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@ggallotti ggallotti requested a review from iroqueta August 11, 2022 19:30
@ggallotti ggallotti merged commit 78fe760 into master Aug 16, 2022
@ggallotti ggallotti deleted the content-disposition branch August 16, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants