Skip to content

Options Header + CORS Support for API Objects + Rest services. #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 12, 2022
Merged

Options Header + CORS Support for API Objects + Rest services. #602

merged 6 commits into from
Sep 12, 2022

Conversation

@ggallotti
Copy link
Member

@ggallotti ggallotti commented Aug 5, 2022

Related to #585

Issue:96724

@genexusbot
Copy link
Collaborator

genexusbot commented Aug 5, 2022

Cherry pick to beta success

@ggallotti ggallotti added testing required This issue has not been tested yet by Product Team work in progress labels Aug 15, 2022
@genexusbot
Copy link
Collaborator

genexusbot commented Aug 17, 2022

Cherry pick to beta success

@ggallotti ggallotti changed the title Read CORS AllowOrigin configuration from client.cfg and Env Vars Options Header + CORS Support for API Objects + Rest services. Aug 17, 2022
@ggallotti
Revert "#New: Add OPTIONS Method for All Java WebServices (REST + API…
d5dd273 
… Objects). Add "Allow" Headers + CORS Headers."

This reverts commit cd58958.
@genexusbot
Copy link
Collaborator

genexusbot commented Aug 18, 2022

Cherry pick to beta success

@genexusbot
Copy link
Collaborator

genexusbot commented Aug 19, 2022

Manual revert to beta success

@ggallotti ggallotti removed conflict testing required This issue has not been tested yet by Product Team labels Aug 19, 2022
@genexusbot
Copy link
Collaborator

genexusbot commented Aug 19, 2022

Cherry pick to beta success

@genexusbot
Copy link
Collaborator

genexusbot commented Aug 19, 2022

Manual revert to beta success

@genexusbot
Copy link
Collaborator

genexusbot commented Aug 19, 2022

Manual cherry pick to beta success

@genexusbot
Copy link
Collaborator

genexusbot commented Aug 19, 2022

Cherry pick to beta failed, 5 conflicted files in commit cd58958
  • wrappercommon/src/main/java/com/genexus/cors/CORSHelper.java
  • wrapperjakarta/src/main/java/com/genexus/ws/JAXRSCorsFilter.java
  • wrapperjakarta/src/main/java/com/genexus/ws/rs/core/Response.java
  • wrapperjavax/src/main/java/com/genexus/ws/JAXRSCorsFilter.java
  • wrapperjavax/src/main/java/com/genexus/ws/rs/core/Response.java

@genexusbot
Copy link
Collaborator

genexusbot commented Sep 5, 2022

Cherry pick to beta failed, 5 conflicted files in commit cd58958
  • wrappercommon/src/main/java/com/genexus/cors/CORSHelper.java
  • wrapperjakarta/src/main/java/com/genexus/ws/JAXRSCorsFilter.java
  • wrapperjakarta/src/main/java/com/genexus/ws/rs/core/Response.java
  • wrapperjavax/src/main/java/com/genexus/ws/JAXRSCorsFilter.java
  • wrapperjavax/src/main/java/com/genexus/ws/rs/core/Response.java

@ggallotti ggallotti added testing required This issue has not been tested yet by Product Team waiting for review PR waiting for Review and removed conflict work in progress labels Sep 5, 2022
@ggallotti ggallotti requested a review from iroqueta September 8, 2022 13:21
@ggallotti ggallotti removed the testing required This issue has not been tested yet by Product Team label Sep 9, 2022
claudiamurialdo
claudiamurialdo approved these changes Sep 12, 2022
View reviewed changes
Copy link
Collaborator

@claudiamurialdo claudiamurialdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ggallotti ggallotti merged commit 92622ca into master Sep 12, 2022
@ggallotti ggallotti deleted the cors-from-client-cfg branch September 12, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claudiamurialdo claudiamurialdo claudiamurialdo approved these changes

@iroqueta iroqueta Awaiting requested review from iroqueta

Assignees

No one assigned

Labels

bot closed waiting for review PR waiting for Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ggallotti @genexusbot @claudiamurialdo @cinthamo