CSS layers support for web applications #607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Cherry pick to beta failed, 0 conflicted files in commit 099cda2 (warning: no changes merged) |
ggallotti
reviewed
Aug 31, 2022
| private static HashMap<String, Messages> cachedMessages = new HashMap<String, Messages>(); | ||
| private String currentLanguage = null; | ||
| private Vector<Object> userStyleSheetFiles = new Vector<Object>(); | ||
| private String ThemekbPrefix; |
Member
There was a problem hiding this comment.
ThemekbPrefix, ThemeStyleSheet and ThemeUrlbuildNumber should start with lowecase.
ggallotti
requested changes
Aug 31, 2022
Member
ggallotti
left a comment
ggallotti
left a comment
There was a problem hiding this comment.
LGTM!
Some minor Issue around VarNames.
BTW: PR Title should be more descriptive and not include the Issue Number.
Contributor
Author
|
@ggallotti thanks for the review, suggestions taken |
ggallotti
changed the title
ggallotti
approved these changes
Aug 31, 2022
Member
ggallotti
left a comment
ggallotti
left a comment
There was a problem hiding this comment.
Thanks!
Just in case, it seems that latests commits were not included in BETA because of PR conflict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.