Skip to content

Runtime.GetEnvironmentVariable() crash when Environment Variable is not defined #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 28, 2022
Merged

Runtime.GetEnvironmentVariable() crash when Environment Variable is not defined #621

merged 2 commits into from
Oct 28, 2022

Conversation

@ggallotti
Copy link
Member

@ggallotti ggallotti commented Oct 14, 2022 •
edited
Loading

This code will crash in JAVA, when the ENV_VAR is not defined:

&GxCorsEnvironmentVar = Runtime.GetEnvironmentVariable(!"GX_CORS_ALLOW_ORIGIN")
msg(&GxCorsEnvironmentVar.ToString())

Also:

  • Fix code formatting
  • Fix HasEnvironmentVariable returning false if ENVVar = "".

@genexusbot
Copy link
Collaborator

genexusbot commented Oct 14, 2022

Cherry pick to beta success

@ggallotti ggallotti requested a review from sjuarezgx October 14, 2022 12:31
@ggallotti ggallotti changed the title Runtime.GetEnvironmentVariable() crash when ENVVAR is not defined Runtime.GetEnvironmentVariable() crash when Environment Variable is not defined Oct 14, 2022
@ggallotti ggallotti requested a review from iroqueta October 28, 2022 18:05
@ggallotti ggallotti merged commit eb7b1e9 into master Oct 28, 2022
@ggallotti ggallotti deleted the environmentvars-null branch October 28, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iroqueta iroqueta iroqueta approved these changes

@sjuarezgx sjuarezgx Awaiting requested review from sjuarezgx

Assignees

No one assigned

Labels

bot closed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ggallotti @genexusbot @iroqueta @cinthamo