Skip to content

ImageWidth and ImageHeight wasn't working. #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 11, 2023
Merged

ImageWidth and ImageHeight wasn't working. #651

merged 6 commits into from
Jan 11, 2023

Conversation

@tomas-sexenian
Copy link
Contributor

@tomas-sexenian tomas-sexenian commented Jan 3, 2023

Issue 100577

@genexusbot
Copy link
Collaborator

genexusbot commented Jan 3, 2023

Waiting from someone from the organization to review this

ggallotti
ggallotti reviewed Jan 3, 2023
View reviewed changes
@genexusbot
Copy link
Collaborator

genexusbot commented Jan 3, 2023

Waiting from someone from the organization to review this

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 3, 2023
View reviewed changes
@genexusbot
Copy link
Collaborator

genexusbot commented Jan 3, 2023

Waiting from someone from the organization to review this

1 similar comment
@genexusbot
Copy link
Collaborator

genexusbot commented Jan 4, 2023

Waiting from someone from the organization to review this

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 4, 2023
View reviewed changes
@genexusbot
Copy link
Collaborator

genexusbot commented Jan 5, 2023

Waiting from someone from the organization to review this

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 5, 2023
View reviewed changes
java/src/main/java/com/genexus/GxImageUtil.java
try{
if (filePathOrUrl.toLowerCase().startsWith("http://") || filePathOrUrl.toLowerCase().startsWith("https://") ||
(httpContext.isHttpContextWeb() && filePathOrUrl.startsWith(httpContext.getContextPath())))
is = new URL(GXDbFile.pathToUrl( filePathOrUrl, httpContext)).openStream();

Check failure

Code scanning / CodeQL

Server-side request forgery

Potential server-side request forgery due to a [user-provided value](1). Potential server-side request forgery due to a [user-provided value](2).
@genexusbot
Copy link
Collaborator

genexusbot commented Jan 5, 2023

Waiting from someone from the organization to review this

@genexusbot
Copy link
Collaborator

genexusbot commented Jan 5, 2023

Waiting from someone from the organization to review this

@genexusbot
Copy link
Collaborator

genexusbot commented Jan 5, 2023

Waiting from someone from the organization to review this

@genexusbot
Copy link
Collaborator

genexusbot commented Jan 5, 2023

Waiting from someone from the organization to review this

@genexusbot
Copy link
Collaborator

genexusbot commented Jan 5, 2023

Cherry pick to beta success

@tomas-sexenian tomas-sexenian merged commit d97dead into master Jan 11, 2023
@tomas-sexenian tomas-sexenian deleted the ImageManipulationAPI branch January 11, 2023 14:07
tomas-sexenian added a commit that referenced this pull request Jan 16, 2023
@tomas-sexenian @iroqueta
ImageWidth and ImageHeight wasn't working. (#651)
f16695f 
* ImageWidth and ImageHeigth wasnt working.
Issue 100577

* Prettified code and reverted unnecessary changes

* Dummy commit to force automatic merge

Co-authored-by: Tomás Sexenian <tomas-sexenian@users.noreply.github.com>
Co-authored-by: tomas-sexenian <tsexenian@genexus.com>
Co-authored-by: iroqueta <46004974+iroqueta@users.noreply.github.com>
tomas-sexenian added a commit that referenced this pull request Mar 9, 2023
@tomas-sexenian @iroqueta
ImageWidth and ImageHeight wasn't working. (#651)
40e819c 
* ImageWidth and ImageHeigth wasnt working.
Issue 100577

* Prettified code and reverted unnecessary changes

* Dummy commit to force automatic merge

Co-authored-by: Tomás Sexenian <tomas-sexenian@users.noreply.github.com>
Co-authored-by: tomas-sexenian <tsexenian@genexus.com>
Co-authored-by: iroqueta <46004974+iroqueta@users.noreply.github.com>
tomas-sexenian added a commit that referenced this pull request Mar 10, 2023
@tomas-sexenian
Revert "ImageWidth and ImageHeight wasn't working. (#651)"
a87e350 
This reverts commit 40e819c.
tomas-sexenian added a commit that referenced this pull request Mar 13, 2023
@tomas-sexenian @iroqueta
ImageWidth and ImageHeight wasn't working. (#651)
4198f9d 
* ImageWidth and ImageHeigth wasnt working.
Issue 100577

* Prettified code and reverted unnecessary changes

* Dummy commit to force automatic merge

Co-authored-by: Tomás Sexenian <tomas-sexenian@users.noreply.github.com>
Co-authored-by: tomas-sexenian <tsexenian@genexus.com>
Co-authored-by: iroqueta <46004974+iroqueta@users.noreply.github.com>
tomas-sexenian added a commit that referenced this pull request Mar 13, 2023
@tomas-sexenian
Revert "ImageWidth and ImageHeight wasn't working. (#651)"
de013e4 
This reverts commit 4198f9d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggallotti ggallotti ggallotti left review comments

@iroqueta iroqueta iroqueta approved these changes

Assignees

No one assigned

Labels

bot closed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tomas-sexenian @genexusbot @ggallotti @iroqueta @cinthamo