Skip to content

fix: Fix the processing of asynchronous generator functions#313

Merged
viveknair merged 2 commits intonextfrom
vivek/create-async-generator-wrapping
Jun 6, 2025
Merged

fix: Fix the processing of asynchronous generator functions#313
viveknair merged 2 commits intonextfrom
vivek/create-async-generator-wrapping

Conversation

@viveknair
Copy link
Copy Markdown
Contributor

@viveknair viveknair commented Jun 6, 2025

TLDR

Fixes handling of async generator functions in the tracing/wrapping functionality

Summary

This PR addresses an issue with how asynchronous generator functions are processed in the codebase. The fix ensures that async generators are properly wrapped and traced, which was likely causing issues with monitoring or instrumentation of these function types.

Key Changes

  • Added comprehensive changelog entries for the new alpha release
  • Fixed the processing logic for async generator functions (implementation details not shown in diff)

Impact

  • Version management files (.release-please-manifest.json)
  • Project changelog documentation
  • Core tracing/wrapping functionality for async generators

Testing Considerations

  • Verify async generator functions are properly traced and wrapped
  • Test various async generator patterns to ensure compatibility
  • Confirm no regression in regular async functions or synchronous generators
  • Validate that the new version maintains backward compatibility

@viveknair viveknair changed the title fix: Expand the pypi range (#311) ### TL;DR Updated the upper version constraint for opentelemetry-processor-baggage dependency. ### What changed? Increased the upper version constraint for the opentelemetry-processor-baggage dependency from < 0.55.0 to < 0.60.0 in the pyproject.toml file, while maintaining the same lower bound of >= 0.45.0b0. ### How to test? 1. Install the package with the updated dependency constraints 2. Verify that the package works correctly with newer versions of opentelemetry-processor-baggage (up to but not including 0.60.0) 3. Run the existing test suite to ensure compatibility ### Why make this change? This change allows the project to work with newer versions of the opentelemetry-processor-baggage library, providing compatibility with more recent releases while maintaining backward compatibility with existing supported versions. fix: Fix the processing of asynchronous generator functions Jun 6, 2025
@viveknair viveknair marked this pull request as ready for review June 6, 2025 19:50
@viveknair viveknair force-pushed the vivek/create-async-generator-wrapping branch from b16c5ad to 7f8a40e Compare June 6, 2025 19:51
@viveknair viveknair requested a review from dsafreno June 6, 2025 19:54
Copy link
Copy Markdown
Contributor

@dsafreno dsafreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@viveknair viveknair force-pushed the vivek/create-async-generator-wrapping branch from 1268bff to 0ab511f Compare June 6, 2025 20:27
@viveknair viveknair merged commit bec5004 into next Jun 6, 2025
8 checks passed
@stainless-app stainless-app bot mentioned this pull request Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants